fix(lambda-api): track api key usage #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
force-pushed
the
feat/track-api-usage
branch
from
6e6def4
to
83afa21
Compare
blacha
commented
Jul 20, 2020
| @@ -77,34 +77,4 @@ o.spec('xyz-request', () => { | |||
| 'x-linz-request-id': [{ key: 'x-linz-request-id', value: String(res.header(HttpHeader.RequestId)) }], | |||
| }); | |||
| }); | |||
|
|
|||
| o('should not cache WMTSCapabilities', async () => { | |||
There was a problem hiding this comment.
Adding cache control on the inwards request makes no sense, as this is not served to the client.
Client -> CloudFront -> ApiTrackerLambda -> TileLambda -> CloudFront -> Client
There was a problem hiding this comment.
Are we setting it on the outwards response? - Yes we are
|
This pull request introduces 3 alerts when merging 83afa21 into 7b724a3 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/track-api-usage
branch
from
83afa21
to
ef6f78a
Compare
|
This pull request introduces 2 alerts when merging ef6f78a into 7b724a3 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/track-api-usage
branch
from
ef6f78a
to
2bd60b0
Compare
|
This pull request introduces 1 alert when merging 2bd60b0 into 7b724a3 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/track-api-usage
branch
from
2bd60b0
to
59390e4
Compare
|
This pull request introduces 1 alert when merging 59390e4 into 7b724a3 - view on LGTM.com new alerts:
|
blacha
force-pushed
the
feat/track-api-usage
branch
3 times, most recently
from
53f2697
to
27ec696
Compare
blacha
force-pushed
the
feat/track-api-usage
branch
from
27ec696
to
2e39435
Compare
blacha
commented
Jul 20, 2020
|
|
||
| const response = new LambdaHttpResponse(100, 'Continue'); | ||
| // Api key will be trimmed from the forwarded request so pass it via a well known header |
There was a problem hiding this comment.
These are now being proxied through to the tiler lambda
jacott
reviewed
Jul 21, 2020
jacott
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.