feat(sprites): support non svg sprites #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds support for `--extension .png` to load png (or any other format that libvips supports) as sprites
ajacombs
approved these changes
Mar 16, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
This is a breaking API change but was published with a minor version number. |
|
@jleedev you are correct, this was not taged as a breaking change (missing a We have a couple options, depending on the impact for you:
|
|
Based on github code search, openstreetmap-americana might be the only code out there that is actually importing this api. so doing nothing is probably fine. |
jleedev
added a commit
to osm-americana/openstreetmap-americana
that referenced
this pull request
Aug 8, 2023
Update sprites parameter (linz/basemaps#2736)
jleedev
added a commit
to osm-americana/openstreetmap-americana
that referenced
this pull request
Aug 12, 2023
Update sprites parameter (linz/basemaps#2736)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for
--extension .pngto load png (or any other format that libvips supports) as sprites