fix(server): Add lerc external into server package. #3348
Conversation
packages/server/Dockerfile
Outdated
| @@ -12,6 +12,8 @@ WORKDIR /app/basemaps | |||
| COPY ./basemaps-landing*.tgz /app/basemaps/ | |||
| COPY ./basemaps-server*.tgz /app/basemaps/ | |||
|
|
|||
| RUN npm install lerc@^4.0.4 | |||
There was a problem hiding this comment.
why is this needed here? if we were missing binary deps then sharp should be missing too?
There was a problem hiding this comment.
I didn't see an error related sharp when I test the server container with screenshots. Might be the deps for cogify in the cli container? But we definitely need to install lerc in here to make it work.
packages/cli/Dockerfile
Outdated
| @@ -15,7 +15,7 @@ RUN apt-get update | |||
| RUN apt-get install -y nodejs | |||
|
|
|||
| # Install sharp TODO update this when we change sharp versions | |||
| RUN npm install sharp@0.33.0 | |||
| RUN npm install sharp@0.33.0 lerc@^4.0.4 | |||
There was a problem hiding this comment.
where in the CLI is this needed?
There was a problem hiding this comment.
We use this cli container for the server in basemaps-config. So we need to install lerc this into cli container.
There was a problem hiding this comment.
if the server is being installed it should come with lerc so I think the server is just missing the lerc dep? how is sharp defined in basemaps/server ?
There was a problem hiding this comment.
sharp is installed as dependency already in the basemaps/server
But we are not installing sharp in the basemaps/cli, so we installed into container directly.
There was a problem hiding this comment.
I don't think server package is installed in the container, it is just a function call to the package/server, so we still need to install lerc in the cli container.
Motivation
It looks like we are missing lerc in the server cli.
https://github.com/linz/basemaps-config/actions/runs/11061552896/job/30734619452?pr=970
Modifications
Add the
lercinto server and cli packageVerification
Local build server container with lerc uninstall vs installed.
UNINSTALL
INSTALLED