Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(landing): copy link button #827

Merged
merged 1 commit into from
Jun 26, 2020
Merged

feat(landing): copy link button #827

merged 1 commit into from
Jun 26, 2020

Conversation

blacha
Copy link
Member

@blacha blacha commented Jun 26, 2020

image

onclick:

image

@blacha blacha force-pushed the feat/copy-link-button branch 2 times, most recently from 1456496 to eea8616 Compare June 26, 2020 01:43
@blacha blacha changed the title feat(landing):copy link button feat(landing): copy link button Jun 26, 2020
@@ -38,7 +38,7 @@ button {
}

#map .ol-zoom-in {
border-radius: 4px 4px 0 0;
border-radius: 3 0 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? where are the units or %? why repeat the three but not the zero?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh thats a bad copy pasta

right: 0;
right: -348px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why set right twice?

@kodiakhq kodiakhq bot merged commit 321334f into master Jun 26, 2020
@kodiakhq kodiakhq bot deleted the feat/copy-link-button branch June 26, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants