fix(cli): mitigate polygon intersection errors #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacott
force-pushed
the
fix/cli/mitigate-cutline-problems
branch
from
8f25066
to
8d2c937
Compare
jacott
force-pushed
the
fix/cli/mitigate-cutline-problems
branch
4 times, most recently
from
be5f538
to
7cdee44
Compare
|
This pull request introduces 1 alert when merging 7cdee44 into 4c4e155 - view on LGTM.com new alerts:
|
jacott
force-pushed
the
fix/cli/mitigate-cutline-problems
branch
from
7cdee44
to
7b96808
Compare
|
This pull request introduces 1 alert when merging 7b96808 into 4c4e155 - view on LGTM.com new alerts:
|
jacott
force-pushed
the
fix/cli/mitigate-cutline-problems
branch
2 times, most recently
from
cd33f16
to
d998617
Compare
blacha
requested changes
Jul 3, 2020
Use clipline to reduce polygon when we don't care about degenerate edges. When we do care call intersection to remove the degenerate edges. Store image bounds not polygons in SourceMetadata and also store in CogJob. This reduces floating-point errors when combining source imagery bounds into composite polygons. Note: The Martinez polygon-clipping libraries can suffer from errors when lines align. Other intersection libraries are intractable for the size of coastline polygons. A solution is to call intersection after first calling clipline.
jacott
force-pushed
the
fix/cli/mitigate-cutline-problems
branch
from
d998617
to
6c44bdc
Compare
blacha
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use clipline to reduce polygon when we don't care about degenerate edges. When we do care call
intersection to remove the degenerate edges.
Store image bounds not polygons in SourceMetadata and also store in CogJob. This reduces
floating-point errors when combining source imagery bounds into composite polygons.
Note:
The Martinez polygon-clipping libraries can suffer from errors when lines align. Other intersection
libraries are intractable for the size of coastline polygons. A solution is to call intersection
after first calling clipline.