Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SRVTRI-3123 Add defaultPostSort option #470

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

kaga
Copy link
Contributor

@kaga kaga commented Aug 30, 2024

See https://linz.slack.com/archives/C044T4WFFT4/p1724976207632129

Add a new optional parameter defaultPostSort to override post sort behavior (new item to last), default to true.

Author Checklist

  • appropriate description or links provided to provide context on the PR
  • self reviewed, seems easy to understand and follow
  • reasonable code test coverage
  • change is documented in Storybook and/or markdown files

Reviewer Checklist

  • Follows convention
  • Does what the author says it will do
  • Does not appear to cause side effects and breaking changes
    • if it does cause breaking changes, those are appropriately referenced

Post merge

  • Post about the change in #lui-cop

Conventional Commit Cheat Sheet:
build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
ci: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs)
docs: Documentation only changes
feat: A new feature
fix: A bug fix
perf: A code change that improves performance
refactor: A code change that neither fixes a bug nor adds a feature
test: Adding missing tests or correcting existing tests

@kaga kaga requested review from matttdawson and jfee-linz and removed request for matttdawson August 30, 2024 01:14
Copy link
Collaborator

@matttdawson matttdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaga kaga merged commit 23ca37c into master Aug 30, 2024
7 checks passed
@kaga kaga deleted the feat/default-post-sort-option branch August 30, 2024 01:46
Copy link

🎉 This PR is included in version 21.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants