Fix decodeRawTransaction network addresses #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjablack
force-pushed
the
fix-decode-raw-tx-network
branch
3 times, most recently
from
b536229
to
daf7704
Compare
matthewjablack
force-pushed
the
fix-decode-raw-tx-network
branch
from
daf7704
to
453e996
Compare
monokh
approved these changes
Oct 7, 2020
| const { hex, fee } = await this._buildTransaction(transactions, feePerByte) | ||
| await this.getMethod('sendRawTransaction')(hex) | ||
| return normalizeTransactionObject(decodeRawTransaction(hex), fee) | ||
| return normalizeTransactionObject(decodeRawTransaction(hex, network), fee) |
There was a problem hiding this comment.
would be clearer to just pass this._network here and avoid the reassignment
| @@ -56,12 +57,14 @@ export default superclass => class BitcoinWalletProvider extends superclass { | |||
| } | |||
|
|
|||
| async sendSweepTransaction (externalChangeAddress, feePerByte, outputs, fixedInputs) { | |||
| const network = this._network | |||
| } | ||
|
|
||
| async updateTransactionFee (tx, newFeePerByte) { | ||
| const network = this._network |
| @@ -237,6 +240,7 @@ export default superclass => class BitcoinWalletProvider extends superclass { | |||
| } | |||
|
|
|||
| async getInputsForAmount (_targets = [], _feePerByte, fixedInputs = [], numAddressPerCall = 100, sweep = false) { | |||
| const network = this._network | |||
|
Good point @monokh. Updated to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes decodeRawTransaction network addresses.
Submission Checklist 📝
decodeRawTransactionis passed network