Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependency slf4j-simple #127

Closed
dmbakker opened this issue Jan 10, 2024 · 1 comment · Fixed by #154
Closed

Please remove dependency slf4j-simple #127

dmbakker opened this issue Jan 10, 2024 · 1 comment · Fixed by #154
Assignees

Comments

@dmbakker
Copy link

Upgrading to liquibase-db2i version 4.25.1 breaks our unit tests that test logging. That version upgraded the dependency liquibase-parent-pom to 0.3.4 and introduced 2 new dependencies from which slf4j-simple is taking over as our logger but does not work with our testappender. Please make the dependency scope provided or remove it from the pom. I also think you should choose either slf4j-api or slf4j-simple.

@jandroav
Copy link
Contributor

jandroav commented Mar 8, 2024

Hey @dmbakker we can make it scope provided but it seems the API and its implementation needs to be declared: https://www.slf4j.org/manual.html#projectDep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants