-
Notifications
You must be signed in to change notification settings - Fork 36
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This commit message will be a QA like ocmmit message Why in the spec and not somewhere else? Historically we are using the same spec in create request an responses, we do not return with status on create request because it's mostly empty. The uuid could be there, but on create there is no status yet. Why is it set on create request? We can't return the uuid in the response if it's not generated and without the uuid they can't delete the resource, it would be a disaster if capmvm sends a request to create ns1/mvm1, then it wants to delete it even before we created the resources. If the delete request would be only ns1/mvm1 it would delete the old one, or basically any other microvms that has the same name and namespace (coming from other management clusters). Why is it global and not microvm specific? It seems logical and generating and maintaining a unique id shouldn't be the job of the microvm provider, their responsibility should be to manage microvms, metadata and other stuffs are provider independent. Fixes #291 rename field to be uid instead of uuid because it is an ulid now remove id and ns from get and delete endpoints
- Loading branch information
Showing
52 changed files
with
567 additions
and
554 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.