Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: return void in handle method of the listener #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

FIX: return void in handle method of the listener #20

wants to merge 3 commits into from

Conversation

77media-creations
Copy link

@77media-creations 77media-creations commented Aug 22, 2022 •
edited
Loading

This will fix the issue where the app cannot listen to the laravel event NotificationSending as the listener in the package is returning $event that causes the notification to be processed ignoring other listeners of the same event being called (or ignored).

Fixes #19

@77media-creations 77media-creations changed the title return void in handle method of the listener FIX: return void in handle method of the listener Aug 22, 2022
@77media-creations
Copy link
Author

@liran-co - Any chance you could look into this please?

@stijnvanouplines
Copy link

@liran-co can you please have a look at this PR? Because of this it's not compatible with Spatie's laravel-notification-log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The package doesn't let you use the NotificationSending listener in the app
2 participants
@77media-creations @stijnvanouplines