Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep track of Weight v1.5 and Weight v2 from Substrate #803

Closed
BillyWooo opened this issue Aug 31, 2022 · 2 comments · Fixed by #1043
Closed

Keep track of Weight v1.5 and Weight v2 from Substrate #803

BillyWooo opened this issue Aug 31, 2022 · 2 comments · Fixed by #1043
Assignees
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days

Comments

@BillyWooo
Copy link
Collaborator

Context

New version of Weight will be introduced in new Substrate release.

Follow this PR and forum discussion.

Task

Keep track of new release and update accordingly.

Acceptance criteria

As usual, CI should pass after the update.


✔️ Please set appropriate labels and assignees if applicable.

@BillyWooo BillyWooo self-assigned this Aug 31, 2022
@Kailai-Wang Kailai-Wang added I2-medium should be completed within 10 working days D1-feature A new feature, a piece of functionality that needs to be developed labels Aug 31, 2022
@Kailai-Wang
Copy link
Collaborator

This issue can be served as the epic and we can add subtasks as bullet points into it (e.g. changes needed to fix the compilation due to v1.5 introduction later).

We might need a sharing session about these too.

@Marky-Shi
Copy link
Contributor

Marky-Shi commented Oct 19, 2022

The PR that some basic arithmetic operations are impl for weight.
The PR that add storage size component to weights.
The PR that set the max proof size weight on defaults and tests.
The PR that remove ord impl for weight V2 and use comparsion fns instead.
Then we can pay attention to the progress of this issue, it basically covers all the progress of weight V2 development.

@BillyWooo BillyWooo linked a pull request Dec 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I2-medium should be completed within 10 working days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants