Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: pyright incompatability #518

Closed
4 tasks
adhtruong opened this issue Mar 29, 2024 · 1 comment · Fixed by #571
Closed
4 tasks

Bug: pyright incompatability #518

adhtruong opened this issue Mar 29, 2024 · 1 comment · Fixed by #571
Labels
bug Something isn't working

Comments

@adhtruong
Copy link
Collaborator

adhtruong commented Mar 29, 2024

Description

Pyright emits typing errors for accessing generic instance variables through classes.

Potentially related pyright issues:

URL to code causing the issue

No response

MCVE

# Your MCVE code here

Steps to reproduce

1. Update pre-commit to v1.1.356 
2. Run pre-commit commits
3. See that `error: Access to generic instance variable through class is ambiguous (reportGeneralTypeIssues)` is emitted for usages of generic class vars.

Screenshots

"In the format of: ![SCREENSHOT_DESCRIPTION](SCREENSHOT_LINK.png)"

Logs

No response

Release Version

main

Platform

  • Linux
  • Mac
  • Windows
  • Other (Please specify in the description above)

Note

While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.

Check out all issues funded or available for funding on our Polar.sh dashboard

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
  • This, along with engagement in the community, helps us know which features are a priority to our users.
Fund with Polar
@adhtruong adhtruong added the bug Something isn't working label Mar 29, 2024
@guacs
Copy link
Member

guacs commented Apr 1, 2024

Is there something we can do to fix this? I think the only option is to just # pyright: ignore[...] the affected (effected? idk english is annoying at times) lines right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants