Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial migration to the TOML version catalog #13

Closed
sergeykad opened this issue Dec 30, 2021 · 3 comments
Closed

Initial migration to the TOML version catalog #13

sergeykad opened this issue Dec 30, 2021 · 3 comments

Comments

@sergeykad
Copy link

Is it possible to implement migration (--create) to to the catalog using the currently used dependencies versions? Migrating everything to the latest versions can be problematic in larger projects.
The option to generate sensible aliases and replace existing dependencies with catalog references will be also great.

@hvisser
Copy link
Contributor

hvisser commented Dec 30, 2021

Yes, create was a bit bolted on to get started, but keeping the current versions for create makes sense.

Generating sensible aliases is very subjective, currently there is some logic to not repeat the module name if the group name ends with it for example, but it is expected that you go in and change the keys to your liking and remove dependencies that are reported but do not need an entry in the catalog. The latter is inevitable because there's no good way to know where a dependency is coming from, e.g. if you declared it or if some plugin is contributing it.

If you have suggestions on how to make the default keys more suitable then let me know.

Updating the actual build files with references from the catalog I consider out of scope for this plugin. There's no good way to do this, except for regexp find and replace and I don't want to go there risking messing up your build files. There might be other plugins that do this that you could apply for this one time conversion.

@konikvranik
Copy link

My suggestion for new keys creation: #15

@sergeykad
Copy link
Author

sergeykad commented Jan 9, 2022

@hvisser Thanks for the detailed answer. Just keeping the current versions will be a huge help.

I want to use the plugin for migration to the new version catalog, at least initially. Doing it all manually for a few hundred unique dependencies is a bit too much.

@sergeykad sergeykad changed the title Migration to version catalog Initial migration to the TOML version catalog Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants