Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons within the Welcome to Livebook markdown sections do not render #521

Closed
mrjoelkemp opened this issue Aug 28, 2021 · 1 comment · Fixed by #522
Closed

Icons within the Welcome to Livebook markdown sections do not render #521

mrjoelkemp opened this issue Aug 28, 2021 · 1 comment · Fixed by #522

Comments

@mrjoelkemp
Copy link
Contributor

mrjoelkemp commented Aug 28, 2021

This is with the latest livebook main branch pulled down locally.

Current behavior

I might be wrong here (new to the sourcecode), but it seems like the inability to render html inside of markdown (it getting sanitized) (possibly related to #512) might be why the icons in the Welcome to Livebook notebook aren't rendering:

An example from the Sections section of that livebook:

image

Notice how it says Click on the "Book" icon () and doesn't render the book icon.

Looking at the markdown in that section, you see an attempt at rendering an <i> tag with a css class:

image

  • Even if you change the css class to rl-booklet-fill (which is the class for the book icon), you still don't see the icon.

Looking at the rendered html, you see an <i> tag that doesn't have any css classes in it:

image

I'm not sure if there should be a set of approved classes to avoid stripping or if the fix is to not try to reference those icons/classes at all.

Expected behavior

Seems like we expect the icons to render when referenced within the markdown sections.

@jonatanklosko
Copy link
Member

Missed that in #495. Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants