Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squareroot not rendering #683

Closed
dustinfarris opened this issue Nov 6, 2021 · 2 comments · Fixed by #684
Closed

squareroot not rendering #683

dustinfarris opened this issue Nov 6, 2021 · 2 comments · Fixed by #684

Comments

@dustinfarris
Copy link

Environment

  • Elixir & Erlang/OTP versions (elixir --version): 1.12.3
  • Operating system: macos monterey
  • How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): mix phx.server and fly.io
  • Livebook version (use git show if running with mix): 6bf2f9c
  • Browsers that reproduce this bug (the more the merrier): safari, firefox, chrome
  • Include what is logged in the browser console: nothing relevant
  • Include what is logged to the server console: nothing relevant

Current behavior

katex is not rendering the square root symbol

image

Expected behavior

should render square root symbol

@josevalim
Copy link
Contributor

I did some investigation. Everything is being parsed correctly. However, the sqrt is rendered using a svg, the svg, for some reason, is not appearing in the DOM. @jonatanklosko, could it be that we are pruning tags after the katex rendering? Maybe we can do it before or not really feasible?

@jonatanklosko
Copy link
Member

@josevalim correct! We should render the math tags after sanitizing, since we trust katex with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants