Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a label for each request. It will be helpful. #133

Closed
kakavip opened this issue Sep 4, 2019 · 14 comments
Closed

Please add a label for each request. It will be helpful. #133

kakavip opened this issue Sep 4, 2019 · 14 comments
Assignees
Labels
discussion Talking over coding feature New feature or request

Comments

@kakavip
Copy link

kakavip commented Sep 4, 2019

When i post or get a request and then i want to use it again. But i don't know where it is... same issue on postman...
Please add a label for each request. :D

@liyasthomas
Copy link
Member

liyasthomas commented Sep 4, 2019

History section has entries with Method, Status code, URL, Path, timestamp. Isn't that enough?

@liyasthomas liyasthomas added discussion Talking over coding question Further information is requested labels Sep 4, 2019
@liyasthomas
Copy link
Member

This could be related to #29
A collection of requests with a common label/name would be 💯 helpful. Make a collection of such requests and ability to share them.

@kakavip
Copy link
Author

kakavip commented Sep 6, 2019

when i work with GraphQL. It wasn't enough to find a request quickly. thanks <3

@liyasthomas liyasthomas self-assigned this Sep 19, 2019
@liyasthomas liyasthomas added feature New feature or request hacktoberfest and removed question Further information is requested labels Sep 19, 2019
@sharath2106
Copy link

@liyasthomas I would like to work on this issue. Let me know if no one has claimed to work on this yet.

@liyasthomas
Copy link
Member

@sharath2106 You're welcome. Assigning to you.

@sharath2106
Copy link

@liyasthomas You should be getting a PR by today or tomorrow. First timer here.

@liyasthomas
Copy link
Member

liyasthomas commented Oct 1, 2019

@sharath2106
There is always a first.

@liyasthomas
Copy link
Member

@sharath2106 just thought I should ping you for PR.

@sharath2106
Copy link

sharath2106 commented Oct 4, 2019

@liyasthomas Done with setting up data and the text box for the request name. Rendering the same in the history section is not happening even after introducing the fields in history.vue component and index.vue.

Screenshot 2019-10-04 at 7 51 03 AM

Screenshot 2019-10-04 at 7 50 53 AM

@liyasthomas
Copy link
Member

liyasthomas commented Oct 4, 2019

History data is fetched from localStorage. And also binded to it. After sending a request, check Dev tools > Application tab > Local storage > http://localhost:300 > history to see entries.

If label is missing in it, it means label is not written to localStorage.

@sharath2106
Copy link

sharath2106 commented Oct 4, 2019

@liyasthomas

This is the local storage -

Screenshot 2019-10-04 at 10 43 29 AM

Have tried to print the history entry in the console

Screenshot 2019-10-04 at 10 42 44 AM

@liyasthomas
Copy link
Member

@sharath2106 everything seems okay to me.

<input aria-label="Label" type="text" readonly :value="entry.label">

Add 👆 this to history.vue

<ul v-for="(entry, index) in filteredHistory" :key="index" class="entry">

(👈 here)

....
......
....

</ul>

And repost.

@sharath2106
Copy link

@liyasthomas Have already added those lines and then docker-compose up.

Screenshot 2019-10-04 at 11 11 24 AM

@liyasthomas
Copy link
Member

liyasthomas commented Oct 4, 2019

@sharath2106 could make a PR for all changes till now, I'll look into it.

Btw, latest version is not updated to Docker because of an issue on nuxt build from latest NuxtJS v2.10.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Talking over coding feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants