Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url request with / at eol #275

Closed
genk1 opened this issue Nov 7, 2019 · 1 comment
Closed

Allow url request with / at eol #275

genk1 opened this issue Nov 7, 2019 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@genk1
Copy link

genk1 commented Nov 7, 2019

Is your feature request related to a problem? Please describe.
When we request api URL with slush - / at the end, it returns Error
Error in event handler: TypeError: Failed to construct 'URL': Invalid URL

Describe the solution you'd like
A clear and concise description of what you want to happen.
It can work both with or without slush - / at the end of API URL.

Describe alternatives you've considered
Shows us error in view, like immediate validation error on that URL fields not only in web Inspector,

Additional context
NA

@liyasthomas
Copy link
Member

Closed by accident. Sorry.

Regarding "/" at rhe end:
We have seperate fields for URL and Path. The "/" part usually goes with the Path field. Anyway this is still an issue. We have a PR (WIP) redy to be deployed #189 . When it lands, this issue will be solved.

Thanks for bring this issue upfront. We'll investigate the quickest solution for this, meanwhile use slash on Path field or if theres no Path field, simple remove the "/"

@liyasthomas liyasthomas added bug Something isn't working help wanted Extra attention is needed labels Nov 7, 2019
@liyasthomas liyasthomas self-assigned this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants