Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling with Tailwindcss #38

Closed
diego81b opened this issue Aug 23, 2019 · 8 comments
Closed

Styling with Tailwindcss #38

diego81b opened this issue Aug 23, 2019 · 8 comments
Labels
future Scheduled to near future

Comments

@diego81b
Copy link

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Same opinionated question 😄: why didn't move to a css framework, for example Tailwindcss ? I think we could gain benefit on already done variation for screen size, theming, and an increasing community

Describe alternatives you've considered
No

Additional context
No
@liyasthomas
Copy link
Member

liyasthomas commented Aug 23, 2019 •
edited
Loading

Wow, thats not a relavent feature.

UPDATE: I'll reconsider integrating a CSS framework if it demands.

@liyasthomas liyasthomas added the future Scheduled to near future label Aug 23, 2019
@Ryanb58
Copy link

Ryanb58 commented Aug 23, 2019

Tailwindcss is a cool framework. I think we should mock up the existing design using it before pursuing this in the main project.

I'll volunteer to do the mockup if this comment gets enough interest.

@liyasthomas
Copy link
Member

@Ryanb58 you'll have enough support from me.

@Ryanb58
Copy link

Ryanb58 commented Aug 23, 2019 •
edited
Loading

You can follow along with the progress if you want:

https://jsfiddle.net/Ryanb58/jo4g6tpu/

@liyasthomas
Copy link
Member

Tailwind integration looks promising. So far so good ✌️🔥

@Ryanb58
Copy link

Ryanb58 commented Aug 25, 2019

I am feeling pretty confident in tailwindcss to replicate the existing design.

Do you want us to move forward with this switch @liyasthomas ? I don't see this as a critical task right now, so if there are more pressing matters, I am open to switching to them before putting significant time into this one.

@liyasthomas
Copy link
Member

liyasthomas commented Aug 25, 2019 •
edited
Loading

At present, tailwindcss integration isn't that much relavent. I need you to see the status of #55.

@liyasthomas
Copy link
Member

Closing absolute issues

AndrewBastin added a commit that referenced this issue Apr 11, 2023
@AndrewBastin
refactor: update mailer service to stop using postmark (#38)
e978541 
* refactor: update mailer service to stop using postmark

* chore: remove postmark as a dep and move out postmark code

* chore: remove postmark variables from .env.example

* chore: add formal errors for mailer initialization errors

* chore: add and update jsdoc comments in mailer service methods
AndrewBastin added a commit that referenced this issue Apr 11, 2023
@ankitsridhar16 @balub @AndrewBastin
feat: Introducing Admin Module to Backend (HBE-83) (#21)
f78354a 
* feat: introducing admin module, resolvers and service files as a module

* feat: adding admin module in the app module

* feat: introducing admin guard and decorator for allowing admin operations

* feat: invited user model

* chore: added user invitation mail description to mailer service

* chore: added admin and user related error

* feat: added invited users as a new model in prisma

* chore: added admin related topics to pubsub

* chore: added service method to fetch all users from user table

* chore: added user deletion base implementation

* Revert "chore: added user deletion base implementation"

This reverts commit d1615ad83db2bae946e2d366a903d2f95051dabb.

* feat: adding team related operations to admin

* chore: adding admin related service methods to teams module service

* chore: adding admin related service methods to team coll invitations requests envs

* chore: added more module error messages

* chore: added admin check service method

* chore: added find individual user by UID in admin

* HBE-106 feat: introduced code to handle first time admin login setup (#23)

* test: wrote test cases for verifyAdmin route service method

* chore: added comments to verifyAdmin service method

* chore: deleted the prisma migration file

* chore: added find admin users

* feat: added user deletion into admin module

* chore: admin user related errors

* chore: fixed registry pattern in the shortcodes and teams to handle user deletion

* chore: add subscription topic for user deletion

* chore: updated user type in data handler

* feat: implement and fix user deletion

* feat: added make user admin mutation

* chore: added unit tests for admin specific service methods in admin module

* chore: added invitation not found error

* chore: added admin specific operation test cases in specific modules

* chore: added tests related to user deletion and admin related operation in user module

* chore: updated to error constant when invitations not found

* chore: fix rebase overwritten methods

* feat: implement remove user as admin

* chore: add new line

* feat: introducing basic metrics into the self-hosted admin module (HBE-104) (#43)

* feat: introducing admin module, resolvers and service files as a module

* feat: adding admin module in the app module

* feat: introducing admin guard and decorator for allowing admin operations

* feat: invited user model

* chore: added user invitation mail description to mailer service

* chore: added admin and user related error

* feat: added invited users as a new model in prisma

* chore: added admin related topics to pubsub

* chore: added service method to fetch all users from user table

* chore: added user deletion base implementation

* Revert "chore: added user deletion base implementation"

This reverts commit d1615ad83db2bae946e2d366a903d2f95051dabb.

* feat: adding team related operations to admin

* chore: adding admin related service methods to teams module service

* chore: adding admin related service methods to team coll invitations requests envs

* chore: added more module error messages

* chore: added admin check service method

* chore: added find individual user by UID in admin

* HBE-106 feat: introduced code to handle first time admin login setup (#23)

* test: wrote test cases for verifyAdmin route service method

* chore: added comments to verifyAdmin service method

* chore: deleted the prisma migration file

* chore: added find admin users

* feat: added user deletion into admin module

* chore: admin user related errors

* chore: fixed registry pattern in the shortcodes and teams to handle user deletion

* chore: add subscription topic for user deletion

* chore: updated user type in data handler

* feat: implement and fix user deletion

* feat: added make user admin mutation

* chore: added unit tests for admin specific service methods in admin module

* chore: added invitation not found error

* chore: added admin specific operation test cases in specific modules

* chore: added tests related to user deletion and admin related operation in user module

* chore: updated to error constant when invitations not found

* chore: fix rebase overwritten methods

* feat: implement remove user as admin

* chore: add new line

* chore: created new GQL return type for admin module

* chore: created resolver and service method for method to fetch org metrics

* chore: removed all entities relevant to seperate query for fetching admin metrics

* chore: created all resolvers for metrics

* feat: completed adding field resolves to query org metrics

* test: wrote tests for all metrics related methods in admin module

* test: added test cases for get count functions in multiple modules

* chore: removed prisma migration folder

* Delete backend-schema.gql

* chore: resolved merge conflicts in team test file

---------

Co-authored-by: ankitsridhar16 <ankit.sridhar16@gmail.com>

* refactor: update mailer service to stop using postmark (#38)

* refactor: update mailer service to stop using postmark

* chore: remove postmark as a dep and move out postmark code

* chore: remove postmark variables from .env.example

* chore: add formal errors for mailer initialization errors

* chore: add and update jsdoc comments in mailer service methods

* chore: added user invitation mail description to mailer service

* chore: updated with review changes requested for admin module

* feat: adding admin resolver to gql schema

* feat: adding input args for admin resolvers

* chore: invited user renamed

* chore: updated mailer service to be compatible with new mailer

* chore: updated team service with review changes

* chore: updated team collection service with review changes

* chore: updated team environments service with review changes

* chore: updated team requests service with review changes

* chore: updated user service with review changes

* refactor: invited user model

* chore: review changes implemented

* chore: implemented the review changes for admin, user and teams module

* chore: removed error handling and implemented review changes

* refactor: naming change for IsAdmin

---------

Co-authored-by: Balu Babu <balub997@gmail.com>
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
future Scheduled to near future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ryanb58 @diego81b @liyasthomas