Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Brave Browser anymore #71

Closed
guastallaigor opened this issue Aug 27, 2019 · 5 comments
Closed

Not working on Brave Browser anymore #71

guastallaigor opened this issue Aug 27, 2019 · 5 comments

Comments

@guastallaigor
Copy link
Contributor

guastallaigor commented Aug 27, 2019

Describe the bug
When the project was released, I was using it on Brave and everything was fine. The code right now is very different from before, but is not working anymore.
I know that this is a small project, but I'm just opening this issue because it was working before and now it isn't, maybe it's just a small fix that someone can do it :)

The error message that is showing in the console is:

TypeError: Cannot read property 'className' of undefined

To Reproduce
Open https://liyasthomas.github.io/postwoman/ on a up to date Brave Browser.

Expected behavior
It should work like Chrome, because for me it's still working on Chrome.

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu 18.04 or Window 10
  • Browser Brave
  • Version 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)

Additional context
If you don't want to support Brave you can close this issue, no problem, I can still use it on Chrome.

@izerozlu
Copy link
Contributor

izerozlu commented Aug 27, 2019 via email

@izerozlu
Copy link
Contributor

I'll try to create the required PR tomorrow.

@liyasthomas
Copy link
Member

liyasthomas commented Aug 27, 2019

@guastallaigor @izerozlu have you tried to clear the site's cache perhaps history data too and try again?

@NBTX
Copy link
Contributor

NBTX commented Aug 27, 2019

I cannot reproduce this issue.

  • OS: Windows 10 (1709)
  • Browser: Brave
  • Version 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)

image

Have you installed the PWA or got any cached copies?
Try going to Developer Tools -> (might need to click the double right chevron ») Application tab -> Service Workers -> Unregister and reload the page.

@guastallaigor
Copy link
Contributor Author

Thank you! I did everything @NBTX said and it's working now.

AndrewBastin pushed a commit that referenced this issue Apr 11, 2023
* feat: removed unused dockerfile

* chore: update env example

* chore: env example update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants