♻️ Refactor Functions

[athul]

Make use of ES6+ constructs

• Arrow functions
• Template literals
• Object destructuring (concise code)

[ghost]

DeepCode Report (#d739af)

DeepCode analyzed this pull request.
There is 1 new info report. 1 info report was fixed.

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 27b2a740-104c-11ea-a65a-5f455ab5a299

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 3d227a10-104c-11ea-a65a-5f455ab5a299

[athul]

@NBTX Done ✨ ✨

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 936f1bc0-104d-11ea-a65a-5f455ab5a299

[jamesgeorge007]

Left couple of comments

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4cf755c0-104f-11ea-a65a-5f455ab5a299

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 173ea130-1050-11ea-a65a-5f455ab5a299

[athul]

@jamesgeorge007 Done I guess 😂

Thanks for all your mentoring folks. Funny thing is IDK Vue and Js. I've always wanted to Help

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ad997720-1052-11ea-a65a-5f455ab5a299

[athul]

I guess that most of the Functions refactored on .vue files and I guess thats why all of em are failing(tests). I think this should be closed as of now and I'll create a new PR with just the .js files refactored.

How does that sound?

[athul]

What do you say @liyasthomas @NBTX @jamesgeorge007
Close it, if you feel like this should be closed

[liyasthomas]

@athul no need. I'm quite busy with office stuffs rn, will be able to make this workable with some tweaks.

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: dded9af0-1061-11ea-a65a-5f455ab5a299

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: bd6677b0-1062-11ea-a65a-5f455ab5a299

[TravisBuddy]

Hey @athul,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4d553d80-10ad-11ea-a65a-5f455ab5a299

[TravisBuddy]

Hey @athul,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 93979010-10b5-11ea-a65a-5f455ab5a299

[liyasthomas]

@jamesgeorge007 please take a look at this PR. Contribute to this pull if there's any refactoring left.

[jamesgeorge007]

Just a couple of more tweaks remaining.

[liyasthomas]

🆗

[TravisBuddy]

Hey @athul,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d2be8d70-110a-11ea-b8ff-d5ab8a371226

[TravisBuddy]

Hey @athul,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 26d25620-110c-11ea-b8ff-d5ab8a371226