-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format body option #847
Add format body option #847
Conversation
Hey @sboulema, TravisBuddy Request Identifier: f789d8f0-8fcf-11ea-a26d-2bd2cd942036 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature addition!
But it looks like you haven't handled the case in which the content type isn't JSON.
Add code to hide the button if the content-type isn't a JSON one.
Hey @sboulema, TravisBuddy Request Identifier: 471b0940-8fdd-11ea-a26d-2bd2cd942036 |
Thanks for the review, very valid comment! Button is now hidden for non JSON bodies |
Hey @sboulema, TravisBuddy Request Identifier: bf7df910-9032-11ea-931a-79bfa81bc315 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Adds a button to prettify the json request body.
Shows a toast error if the body isn't a proper json string.
This PR fixes #767.