Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get qr code with enter button #1007

Closed
dhwaj1902 opened this issue Mar 16, 2022 · 6 comments
Closed

Get qr code with enter button #1007

dhwaj1902 opened this issue Mar 16, 2022 · 6 comments
Labels
enhancement to be release Fixed, to be release
Milestone
v1.7

Comments

@dhwaj1902
Copy link
Contributor

Currently, we need to click the generate-button to generate the QR code. We can also use enter to generate the QR code, it will be easier for the user.
image
@codebloded
Copy link
Contributor

are you working on this issue? @dhwaj1902

@dhwaj1902
Copy link
Contributor Author

are you working on this issue? @dhwaj1902

yep!

This was referenced Mar 16, 2022
Closed
Merged
@llaske
Copy link
Owner

llaske commented Mar 19, 2022

Seems like a good idea.

@llaske
Copy link
Owner

llaske commented Mar 19, 2022

Fixed in #1013

@llaske llaske added the to be release Fixed, to be release label Mar 19, 2022
This was referenced Mar 24, 2022
Closed
Closed
@jigyasunigam
Copy link
Contributor

@dhwaj1902 Please close this issue, as it's already resolved.

@AnandChourasia007
Copy link
Contributor

@dhwaj1902 @jigyasunigam , you're not supposed to close an issue with 'to be release' label before the fix being released with the next version. See the last comment on my issue #1004.

@dhwaj1902 dhwaj1902 reopened this Mar 25, 2022
@llaske llaske added this to the v1.7 milestone Mar 28, 2023
@llaske llaske closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Milestone
v1.7
Development

Successfully merging a pull request may close this issue.

generate qr-code on enter dhwaj1902/sugarizer
5 participants
@llaske @codebloded @dhwaj1902 @jigyasunigam @AnandChourasia007