-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chess multiplayer bug when a third player join #1047
Comments
Good point. |
I was unsure of the player counts of other shared games so I only made the fix for chess, should be easy to add other player counts in the constant file though it may be worth adding player counts to the activities themselves for simplicity in creating new activities. |
@jcvails the fix should be done in Chess activity |
@llaske I've fixed the issue and tested it.
|
Fixed in #1345 |
Issue: If a chess match between two players is already going on, attempt to join by a third player is allowed. Any such attempts then actually BREAKS the game and the 1st and 2nd players lose the game status, returning to singleplayer screens.
Suggestion: Since, this activity is supposed to be used by kids, expecting them to 'not click when a chess game is full' is not a good idea. Instead, we can prevent clicking of the join game button after the second player has joined the game.
Chess.multiplayer.3rd.player.BREAKs.the.game.mp4
The text was updated successfully, but these errors were encountered: