Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chess multiplayer bug when a third player join #1047

Closed
AnandChourasia007 opened this issue Mar 28, 2022 · 5 comments
Closed

Chess multiplayer bug when a third player join #1047

AnandChourasia007 opened this issue Mar 28, 2022 · 5 comments
Labels
bug to be release Fixed, to be release
Milestone

Comments

@AnandChourasia007
Copy link
Contributor

Issue: If a chess match between two players is already going on, attempt to join by a third player is allowed. Any such attempts then actually BREAKS the game and the 1st and 2nd players lose the game status, returning to singleplayer screens.
Suggestion: Since, this activity is supposed to be used by kids, expecting them to 'not click when a chess game is full' is not a good idea. Instead, we can prevent clicking of the join game button after the second player has joined the game.

Chess.multiplayer.3rd.player.BREAKs.the.game.mp4
@llaske llaske added the bug label Mar 29, 2022
@llaske llaske changed the title Chess multiplayer bug Chess multiplayer bug when a third player join Mar 29, 2022
@llaske
Copy link
Owner

llaske commented Mar 29, 2022

Good point.
We can't prevent joining the game but we can stop the activity of the third player in this situation.
I guess some other activities do the same. May be Memorize?

@jcvails
Copy link

jcvails commented Apr 20, 2022

I was unsure of the player counts of other shared games so I only made the fix for chess, should be easy to add other player counts in the constant file though it may be worth adding player counts to the activities themselves for simplicity in creating new activities.

@llaske
Copy link
Owner

llaske commented Apr 23, 2022

@jcvails the fix should be done in Chess activity

@UtkarshSiddhpura
Copy link
Contributor

UtkarshSiddhpura commented Mar 24, 2023

@llaske I've fixed the issue and tested it.

  • Other users won't interrupt the game
  • if any player leaves the opponent will be played by computer.

@llaske
Copy link
Owner

llaske commented Mar 30, 2023

Fixed in #1345

@llaske llaske added the to be release Fixed, to be release label Mar 30, 2023
@llaske llaske added this to the v1.8 milestone Apr 10, 2024
@llaske llaske closed this as completed Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug to be release Fixed, to be release
Projects
None yet
Development

No branches or pull requests

4 participants