Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating Elements in PhysicsJs.activity that're Bigger than canvas #1171

Closed
UtkarshSiddhpura opened this issue Jan 28, 2023 · 2 comments
Closed

Creating Elements in PhysicsJs.activity that're Bigger than canvas #1171

UtkarshSiddhpura opened this issue Jan 28, 2023 · 2 comments
Labels
enhancement to be release Fixed, to be release
Milestone
v1.7

Comments

@UtkarshSiddhpura
Copy link
Contributor

  • Collisions are only detected for the top edge of view-port (i.e base of toolbar) for bodies/elements while creating.
  • So elements bigger than canvas are easily possible to create from other edges
  • e.g
    phy

Solution: consider each edge of viewport and stop increase in size once edge is touched.
@llaske
Copy link
Owner

llaske commented Jan 28, 2023

Make sense.

@UtkarshSiddhpura UtkarshSiddhpura mentioned this issue Jan 29, 2023
Merged
@llaske
Copy link
Owner

llaske commented Jan 31, 2023

Fixed in #1172

@llaske llaske added the to be release Fixed, to be release label Jan 31, 2023
@llaske llaske added this to the v1.7 milestone Mar 28, 2023
@llaske llaske closed this as completed Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement to be release Fixed, to be release
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
2 participants
@llaske @UtkarshSiddhpura