Overlapping of icon-background on hover

[rucha0702]

web-activity-icons overlap a little with the icons near them on hovering.

However, it looks fine if the border-radius is set to 50%

sug-ans_Trim.mp4

I would be happy to create a PR if the issue is approved.

[llaske]

You're right there is an overlap on icons in "circle mode" (i.e. when there is no size to draw all icons in the same page as a spiral).
There is no overlap in spiral mode.

I don't like the idea to change border radius, it's not consistent with the Sugar UI.
May be the idea could be to add spaces between icons in circle mode.

FYI all magic regarding spiral/circle mode happen here.

[rucha0702]

Hey, so I went through the homeview.js file you mentioned above and found a constant by the name of iconSpacingFactor over
here that defines the spacing. After a small change in its value, it looked like this.

Before:

After:

Am I doing it right?

[llaske]

Am I doing it right?

Just changing this value will probably affect spacing for both spiral and circle mode.
It will be better to find a solution to fix only the circle mode issue.

[rucha0702]

Am I doing it right?

Just changing this value will probably affect spacing for both spiral and circle mode. It will be better to find a solution to fix only the circle mode issue.

Oh okay, I'll try finding a solution just for the circle mode.

[AnandChourasia007]

Hey @llaske , I think I fixed this issue without affecting the spiral design.
Before

:
After

:
Spiral mode view after changing circular mode view:

Is this good?

[llaske]

@AnandChourasia007 Sounds good.
Please send a PR so I will be able to review it.

[AnandChourasia007]

@llaske I have submitted the PR to the repo from which I had forked which was sugarlabs/sugarizer. After that I saw that most PR have been made to your repo ilaske/sugarizer. Is this fine or should I fork from your repo and submit my PR ?

[llaske]

@AnandChourasia007 the latest repo is https://github.com/llaske/sugarizer . Please send your PR on the dev branch.

[AnandChourasia007]

Yeah sure! Sorry for the trouble.

[AnandChourasia007]

Hey @llaske, after making the fix, to how much extent should I check if the hover effect has been fixed? I mean do I have to ensure that this fixes hover effect all the way down upto mobile phones screen dimensions? Taking mobile responsiveness into account I mean. Because that would require resizing appropriately the inner two icons as well.
This is the current extent to which there is no overlap after fixing:

Is this good? Or should I fix for even more tighter screens.

[llaske]

@AnandChourasia007 You could find a good description of responsive limit of Sugarizer here.

[llaske]

Fixed in 30c4a37