From 241cceb9af844ef7d7a87124407a04b0a64991fe Mon Sep 17 00:00:00 2001 From: "J. Ryan Stinnett" Date: Wed, 2 Aug 2023 18:53:21 +0100 Subject: [PATCH] [Clang][Tooling] Accept preprocessed input files This restores the tooling library's ability to accept invocations that take a preprocessed file as the primary input. Regressed by https://reviews.llvm.org/D105695 Fixes https://github.com/llvm/llvm-project/issues/63941 Differential Revision: https://reviews.llvm.org/D157011 --- clang/lib/Tooling/Tooling.cpp | 7 +++++++ clang/unittests/Tooling/ToolingTest.cpp | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/clang/lib/Tooling/Tooling.cpp b/clang/lib/Tooling/Tooling.cpp index 46a784e44b931a..dc82a1f3772dd2 100644 --- a/clang/lib/Tooling/Tooling.cpp +++ b/clang/lib/Tooling/Tooling.cpp @@ -147,6 +147,13 @@ getCC1Arguments(DiagnosticsEngine *Diagnostics, if (IsCC1Command(Job) && llvm::all_of(Job.getInputInfos(), IsSrcFile)) CC1Jobs.push_back(&Job); + // If there are no jobs for source files, try checking again for a single job + // with any file type. This accepts a preprocessed file as input. + if (CC1Jobs.empty()) + for (const driver::Command &Job : Jobs) + if (IsCC1Command(Job)) + CC1Jobs.push_back(&Job); + if (CC1Jobs.empty() || (CC1Jobs.size() > 1 && !ignoreExtraCC1Commands(Compilation))) { SmallString<256> error_msg; diff --git a/clang/unittests/Tooling/ToolingTest.cpp b/clang/unittests/Tooling/ToolingTest.cpp index ebe03fda78f1ef..354af292a54108 100644 --- a/clang/unittests/Tooling/ToolingTest.cpp +++ b/clang/unittests/Tooling/ToolingTest.cpp @@ -449,6 +449,13 @@ TEST_F(CommandLineExtractorTest, AcceptSaveTemps) { EXPECT_NE(extractCC1Arguments(Args), nullptr); } +TEST_F(CommandLineExtractorTest, AcceptPreprocessedInputFile) { + addFile("test.i", "int main() {}\n"); + const char *Args[] = {"clang", "-target", "arm64-apple-macosx11.0.0", "-c", + "test.i"}; + EXPECT_NE(extractCC1Arguments(Args), nullptr); +} + TEST_F(CommandLineExtractorTest, RejectMultipleArchitectures) { addFile("test.c", "int main() {}\n"); const char *Args[] = {"clang", "-target", "arm64-apple-macosx11.0.0",