Skip to content

Commit

Permalink
[CUDA] CUDA has no device-side library builtins.
Browse files Browse the repository at this point in the history
We should (almost) never consider a device-side declaration to match a
library builtin functio.  Otherwise clang may ignore the implementation
provided by the CUDA headers and emit clang's idea of the builtin.

Differential Revision: https://reviews.llvm.org/D42319

llvm-svn: 323239
  • Loading branch information
Artem-B committed Jan 23, 2018
1 parent 1c7c456 commit 5ecdb94
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
7 changes: 7 additions & 0 deletions clang/lib/AST/Decl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2901,6 +2901,13 @@ unsigned FunctionDecl::getBuiltinID() const {
Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID))
return 0;

// CUDA does not have device-side standard library. printf and malloc are the
// only special cases that are supported by device-side runtime.
if (Context.getLangOpts().CUDA && hasAttr<CUDADeviceAttr>() &&
!hasAttr<CUDAHostAttr>() &&
!(BuiltinID == Builtin::BIprintf || BuiltinID == Builtin::BImalloc))
return 0;

return BuiltinID;
}

Expand Down
22 changes: 22 additions & 0 deletions clang/test/CodeGenCUDA/library-builtin.cu
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// REQUIRES: x86-registered-target
// REQUIRES: nvptx-registered-target

// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -o - %s | \
// RUN: FileCheck --check-prefixes=HOST,BOTH %s
// RUN: %clang_cc1 -fcuda-is-device -triple nvptx64-nvidia-cuda \
// RUN: -emit-llvm -o - %s | FileCheck %s --check-prefixes=DEVICE,BOTH

// BOTH-LABEL: define float @logf(float

// logf() should be calling itself recursively as we don't have any standard
// library on device side.
// DEVICE: call float @logf(float
extern "C" __attribute__((device)) float logf(float __x) { return logf(__x); }

// NOTE: this case is to illustrate the expected differences in behavior between
// the host and device. In general we do not mess with host-side standard
// library.
//
// Host is assumed to have standard library, so logf() calls LLVM intrinsic.
// HOST: call float @llvm.log.f32(float
extern "C" float logf(float __x) { return logf(__x); }

0 comments on commit 5ecdb94

Please sign in to comment.