Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge r355227 and r355228 to 8.0 #40305

Closed
topperc opened this issue Mar 4, 2019 · 2 comments
Closed

Merge r355227 and r355228 to 8.0 #40305

topperc opened this issue Mar 4, 2019 · 2 comments
Labels
backend:X86 bugzilla Issues migrated from bugzilla

Comments

@topperc
Copy link
Collaborator

topperc commented Mar 4, 2019

Bugzilla Link 40960
Resolution FIXED
Resolved on Mar 05, 2019 09:46
Version 8.0
OS Windows NT
Blocks #39678
CC @dbabokin,@topperc,@zmodem,@RKSimon,@rotateright

Extended Description

Hans, is it possible to merge this to 8.0. I know we're getting pretty late.

ISPC folks tell me they are seeing a regression on some test cases with 8.0 that these commits fix.

The gather/scatter intrinsics have been misdeclared for a long time probably since they were added years ago. My reduced test case fails on previous versions llvm.

So I think that means that ISPC is hitting some other optimization change that made them more susceptible to this issue.

@zmodem
Copy link
Collaborator

zmodem commented Mar 5, 2019

We already need to do an rc4, so merging sounds fine. r355383.

@dbabokin
Copy link

dbabokin commented Mar 5, 2019

Thanks Hans! Now we can build with LLVM 8.0 without patches.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:X86 bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

3 participants