Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM 12 regression (GlobalISel): AArch64 backend generates incorrect code for ashr <i8 x 16> #49248

Closed
Amanieu opened this issue Apr 9, 2021 · 7 comments
Assignees
Labels
backend:AArch64 bugzilla Issues migrated from bugzilla

Comments

@Amanieu
Copy link
Contributor

Amanieu commented Apr 9, 2021

Bugzilla Link 49904
Resolution FIXED
Resolved on May 10, 2021 17:48
Version trunk
OS Linux
Blocks #48246 #48661
CC @aemerson,@Arnaud-de-Grandmaison-ARM,@CryZe,@fhahn,@ornata,@nikic,@smithp35,@tstellar
Fixed by commit(s) 40e75ca 24535af

Extended Description

IR:

define <16 x i8> @​simd_ashr(<16 x i8> %a, <16 x i8> %b) {
start:
%0 = ashr <16 x i8> %a, %b
ret <16 x i8> %0
}

llc -march=aarch64 -global-isel=1 -O0 test.ll

simd_ashr: // @​simd_ashr
// %bb.0: // %start
neg v1.8h, v1.8h
sshl v0.16b, v0.16b, v1.16b
ret

The neg instruction should be using .16b instead of .8h.

@Amanieu
Copy link
Contributor Author

Amanieu commented Apr 9, 2021

assigned to @tstellar

@aemerson
Copy link
Contributor

aemerson commented Apr 9, 2021

Thanks! Fixed in 40e75ca

@nikic
Copy link
Contributor

nikic commented Apr 10, 2021

Reopening for LLVM 12 backport (or 12.0.1, depending on where things stand).

@fhahn
Copy link
Contributor

fhahn commented Apr 10, 2021

Thanks! Fixed in 40e75ca

Awesome, thanks Amara!

@tstellar
Copy link
Collaborator

Hi Tim,

What is your opinion on backporting this?

https://reviews.llvm.org/rG40e75cafc0fef365b5580a9c09595ac475db0c19

@TNorthover
Copy link
Contributor

Looks very simple to me, so I say yes.

@tstellar
Copy link
Collaborator

Merged: 24535af

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AArch64 bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

6 participants