Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport [LoopReroll] Fix rerolling loop with extra instructions to 12.0.1 #49437

Closed
kawashima-fj opened this issue Apr 23, 2021 · 4 comments
Closed
Assignees
Labels
bugzilla Issues migrated from bugzilla loopoptim

Comments

@kawashima-fj
Copy link
Member

Bugzilla Link 50093
Resolution FIXED
Resolved on May 06, 2021 17:17
Version trunk
OS Linux
Blocks #48661
CC @kawashima-fj,@tstellar
Fixed by commit(s) d9a9c99 ac593de

Extended Description

Please backport the following commit to version 12.0.1.
It is a fix for the data corruption bug #46971 .

commit d9a9c992d190dd6645ea911b66cf0cadba0dadc3
Author: KAWASHIMA Takahiro <t-kawashima@fujitsu.com>
Date:   2021-04-08 12:33:25 +0900

    [LoopReroll] Fix rerolling loop with extra instructions

I forgot to add Differential Revision: line in the commit message.
It is https://reviews.llvm.org/D88395 .

@kawashima-fj
Copy link
Member Author

assigned to @Meinersbur

@tstellar
Copy link
Collaborator

tstellar commented May 4, 2021

Hi Michael,

What is your opinion on backporting this?

https://reviews.llvm.org/rGd9a9c992d190dd6645ea911b66cf0cadba0dadc3

@Meinersbur
Copy link
Member

Original bug is #46971

I suggested the backporting myself in the discussion of D88395. It's a miscompile bug with straightforward fix (instructions with side effects must not be skipped during legality checks).

@tstellar
Copy link
Collaborator

tstellar commented May 7, 2021

Merged: ac593de

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla loopoptim
Projects
None yet
Development

No branches or pull requests

3 participants