[PowerPC] [MMA] Add lxvp/stxvp and pair assemble/disassemble builtins with _mma_ prefix

[ahsansaghir]

Bugzilla Link	50159
Version	trunk
OS	Linux
Blocks	#48661
CC	@DougGregor,@slacka,@nemanjai,@zygoloid,@tstellar
Fixed by commit(s)	25bbff6

Extended Description

Vector pair intrinsics and builtins were renamed in
https://reviews.llvm.org/D91974 to replace the mma prefix by vsx.
However, some projects used the mma version, so this patch adds
these intrinsics to provide compatibility:

__builtin_mma_lxvp -> __builtin_vsx_lxvp
__builtin_mma_stxvp -> __builtin_vsx_stxvp
__builtin_mma_assemble_pair -> __builtin_vsx_assemble_pair
__builtin_mma_disassemble_pair -> __builtin_vsx_disassemble_pair

[ahsansaghir]

assigned to @hfinkel

[tstellar]

Vector pair intrinsics and builtins were renamed in
https://reviews.llvm.org/D91974 to replace the mma prefix by vsx.
However, some projects used the mma version, so this patch adds
these intrinsics to provide compatibility:

__builtin_mma_lxvp -> __builtin_vsx_lxvp
__builtin_mma_stxvp -> __builtin_vsx_stxvp
__builtin_mma_assemble_pair -> __builtin_vsx_assemble_pair
__builtin_mma_disassemble_pair -> __builtin_vsx_disassemble_pair

Which patch adds the intrinsics?

[ahsansaghir]

Sorry, missed the link for the patch:
Differential Revision: https://reviews.llvm.org/D100482

[ahsansaghir]

Also, there is an update after the review: the patch adds the mma version of the built-ins as aliases to the existing vsx intrinsics.

[ahsansaghir]

Fix checked in: https://reviews.llvm.org/rG25bbff632d018d178272a61c0732203d53d3a2e3

[slacka]

Reopening for 12.x backport

[tstellar]

The fix does not apply cleanly, could someone backport this and push a branch to their local github fork?

[tstellar]

Hi Hal,

What is your opinion on backporting this?

https://reviews.llvm.org/rG25bbff632d018d178272a61c0732203d53d3a2e3

[ahsansaghir]

The fix does not apply cleanly, could someone backport this and push a
branch to their local github fork?

Hi Tom, sorry for the late response. I will work on it to get you a patch that applies cleanly.

Thanks!

[ahsansaghir]

Hi Tom,
I am not aware of the procedure for backporting a patch. I would need some help with that. Is there a branch for 12.0.1 that I can apply my patch to and perhaps upload the diff for the applied patch?

Thanks!

[ahsansaghir]

Hi Hal,

What is your opinion on backporting this?

https://reviews.llvm.org/rG25bbff632d018d178272a61c0732203d53d3a2e3

Nemanja suggested to backport this.

[ahsansaghir]

Hi Tom,
I am not aware of the procedure for backporting a patch. I would need
some help with that. Is there a branch for 12.0.1 that I can apply my patch
to and perhaps upload the diff for the applied patch?

Thanks!

Hi Tom,
I created a branch off of release/12.x and cherry-picked the fix (25bbff6) and it applied cleanly for me. May be I am missing something. Can you please let me know if I am missing something? If not, can you please give it a try to cherry-pick the fix again. Thanks!

[tstellar]

I'm still trying to verify this with the abi-dumper tool, but I think adding these builtins changes the API/ABI, because the values of the builtin enum change. Is there some way to add these alias without adding the enums to BuiltinsPPC.def ?

[ahsansaghir]

I'm still trying to verify this with the abi-dumper tool, but I think adding
these builtins changes the API/ABI, because the values of the builtin enum
change. Is there some way to add these alias without adding the enums to
BuiltinsPPC.def ?

I discussed this with Nemanja and he suggested that if this is causing a significant issue to backport, we should not backport it.
Thanks for your effort Tom, appreciated!

[xgupta]

We can close this issue, as the patch is committed.