Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 82150606fb11d28813ae6 into 12.0.1 #49633

Closed
serge-sans-paille opened this issue May 10, 2021 · 8 comments
Closed

Backport 82150606fb11d28813ae6 into 12.0.1 #49633

serge-sans-paille opened this issue May 10, 2021 · 8 comments
Assignees
@kcc
Labels
bugzilla Issues migrated from bugzilla compiler-rt:asan Address sanitizer

Comments

@serge-sans-paille
Copy link
Collaborator

Bugzilla Link 50289
Resolution FIXED
Resolved on Jun 22, 2021 10:49
Version unspecified
OS Windows NT
Blocks #48661
CC @sylvestre,@tstellar,@vitalybuka
Fixed by commit(s) 8215060 4144827 cc08a27 385a6f3

Extended Description

This fixes asan integration on some systems depending on the glibc version. On those systems, asan is not usable without this patch.
@serge-sans-paille
Copy link
Collaborator Author

assigned to @kcc

@tstellar
Copy link
Collaborator

Do we also need to backport this: https://reviews.llvm.org/D102475 along with it?

@serge-sans-paille
Copy link
Collaborator Author

Yeah, it's important to do so I'd say.

@tstellar
Copy link
Collaborator

Hi Kostya,

What is your opinion on backporting this?

https://reviews.llvm.org/rG82150606fb11d28813ae6da1101f5bda638165fe
https://reviews.llvm.org/rG414482751452e54710f16bae58458c66298aaf69

@kcc
Copy link
Contributor

kcc commented Jun 16, 2021

No opinion, please ask Vitaly (CC-ed)

1 similar comment
@kcc
Copy link
Contributor

kcc commented Jun 16, 2021

No opinion, please ask Vitaly (CC-ed)

@vitalybuka
Copy link
Collaborator

It should be both on nothing:
https://reviews.llvm.org/rG82150606fb11d28813ae6da1101f5bda638165fe
https://reviews.llvm.org/rG414482751452e54710f16bae58458c66298aaf69

It's better if we backport them to help users with newer glibc.

@tstellar
Copy link
Collaborator

Merged: 385a6f3

@tstellar tstellar mentioned this issue Feb 22, 2021
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kcc kcc

Labels
bugzilla Issues migrated from bugzilla compiler-rt:asan Address sanitizer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tstellar @serge-sans-paille @vitalybuka @kcc