Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAssembly] Merge commit 412a3381f721452fb6cd33bc30e7700102639e3f into the 12.0 branch #49768

Closed
dragonroot opened this issue May 20, 2021 · 5 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla

Comments

@dragonroot
Copy link

Bugzilla Link 50424
Resolution FIXED
Resolved on Jun 08, 2021 15:57
Version unspecified
OS Linux
Depends On #49701
Blocks #48661
CC @aheejin,@dschuff,@tstellar
Fixed by commit(s) 412a338 6a86669

Extended Description

Hi,
I'd like to request backporting this commit into 12.0.1. It's a self-contained fix for a bug found in 12.0.0 (see bug 50357).

@dragonroot
Copy link
Author

assigned to @sunfishcode

@tstellar
Copy link
Collaborator

Hi Dan,

What is your opinion on backporting this?

https://reviews.llvm.org/rG412a3381f721452fb6cd33bc30e7700102639e3f

@dragonroot
Copy link
Author

FWIW, I've been running with this fix since it has been made, and the code produced for exception specifications has been working correctly now (unlike before the fix). Tested with -O0, -O3, and with and without -flto. The fix doesn't affect code generation when no exception specifications are present, since it doesn't change the compiler behavior in that case.

@sunfishcode
Copy link
Member

Looks good to me!

@tstellar
Copy link
Collaborator

tstellar commented Jun 8, 2021

Merged: 6a86669

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

3 participants