[clang-tidy] misc-static-assert false-positive

[LebedevRI]

Bugzilla Link	50532
Version	unspecified
OS	Linux
Blocks	#48661
CC	@AaronBallman,@tstellar
Fixed by commit(s)	be6b9e8

Extended Description

https://godbolt.org/z/9q3E1MqEq

[AaronBallman]

Reduced test case:

void foo() {
assert(false);
}

This is sort of not a false positive -- that assert can absolutely be converted into a static_assert. However, I don't think the suggestion is beneficial given how much code uses assert(false) to signify "this code path should not be taken at runtime", so I agree that the diagnostic shouldn't trigger in this case (at least, not without some opt-in option, but I'm not certain what the use case would be for such an option).