Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge f51ab187+7907c46f into 12.x #49887

Closed
hvdijk opened this issue May 31, 2021 · 5 comments
Closed

Merge f51ab187+7907c46f into 12.x #49887

hvdijk opened this issue May 31, 2021 · 5 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla clang-tools-extra

Comments

@hvdijk
Copy link
Contributor

hvdijk commented May 31, 2021

Bugzilla Link 50543
Resolution FIXED
Resolved on Jun 14, 2021 16:23
Version unspecified
OS Linux
Blocks #48661
CC @tstellar
Fixed by commit(s) f51ab18 7907c46 3be5dbb adae177

Extended Description

Can f51ab18+7907c46f please be merged into 12.x to get into the 12.0.1 release?

https://reviews.llvm.org/D96787
https://reviews.llvm.org/D101851

These fixes the build when clang-tools-extra is checked out to clang/tools/extra, which is something that realistically only shows up with releases, not Git checkouts, and broke my 12.0.0 build.

@hvdijk
Copy link
Contributor Author

hvdijk commented May 31, 2021

assigned to @sam-mccall

@tstellar
Copy link
Collaborator

tstellar commented Jun 4, 2021

@sam-mccall
Copy link
Collaborator

These look good to merge, thank you!

@tstellar
Copy link
Collaborator

The fix does not apply cleanly, could someone backport this and push a branch to their local github fork?

@tstellar
Copy link
Collaborator

Merged: adae177

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla clang-tools-extra
Projects
None yet
Development

No branches or pull requests

3 participants