clang mingw driver -mconsole doesn't override earlier -mwindows

[jeremyd2019]

Bugzilla Link	51296
Resolution	FIXED
Resolved on	Oct 11, 2021 20:29
Version	12.0
OS	Windows NT
Blocks	#51489
Attachments	response file showing clang arguments
CC	@mstorsjo,@tstellar
Fixed by commit(s)	ce49fd0 58811fd

Extended Description

I'm running into a situation where a pkg-config file is providing a -mwindows argument, but later the program being built explicitly specified -mconsole. On gcc, this seems to be respected but with clang -mwindows seems to always win.

llvm-project/clang/lib/Driver/ToolChains/MinGW.cpp

Lines 139 to 145 in d28af7c

	if (Args.hasArg(options::OPT_mwindows)) {
	CmdArgs.push_back("--subsystem");
	CmdArgs.push_back("windows");
	} else if (Args.hasArg(options::OPT_mconsole)) {
	CmdArgs.push_back("--subsystem");
	CmdArgs.push_back("console");
	}

[jeremyd2019]

This was fixed in ce49fd0

[mstorsjo]

I think this one is small and trivial enough to warrant backporting to 13.x.

[tstellar]

Merged: 58811fd

[tstellar]

mentioned in issue #51489