Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-rt] Merge 8111f2f7eef50f8c0cdfd4b575e275c0c4b7fc41 into 13.0.0 #50979

Closed
gulfemsavrun opened this issue Aug 26, 2021 · 5 comments
Closed
Labels
bugzilla Issues migrated from bugzilla compiler-rt

Comments

@gulfemsavrun
Copy link
Contributor

Bugzilla Link 51637
Resolution FIXED
Resolved on Sep 07, 2021 22:43
Version unspecified
OS All
Blocks #50580
CC @petrhosek,@tstellar
Fixed by commit(s) 8111f2f 427df19

Extended Description

We need to merge 8111f2f. It addresses the issue that is introduced in e50a388 and discovered in Fuchsia.

@tstellar
Copy link
Collaborator

tstellar commented Sep 2, 2021

This doesn't apply cleanly to the release branch, can you provide a patch or a git branch with the patch applied.

@gulfemsavrun
Copy link
Contributor Author

Patch file
It seems like there is refactoring and cleanup happened in compiler-rt/lib/profile/InstrProfilingFile.c.
So, I just created that patch on top of release/13.x branch.
Please let me know if there are any issues.

@petrhosek
Copy link
Member

Tom, is the attached patch sufficient or would a branch in personal GitHub repository be preferable?

@tstellar
Copy link
Collaborator

tstellar commented Sep 8, 2021

Tom, is the attached patch sufficient or would a branch in personal GitHub
repository be preferable?

I already pushed it to my own branch for testing, so we are all set.

@tstellar
Copy link
Collaborator

tstellar commented Sep 8, 2021

Merged: 427df19

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla compiler-rt
Projects
None yet
Development

No branches or pull requests

3 participants