Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM 13] Backport D109203 #51152

Closed
vchuravy opened this issue Sep 9, 2021 · 7 comments
Closed

[LLVM 13] Backport D109203 #51152

vchuravy opened this issue Sep 9, 2021 · 7 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla tools:llc

Comments

@vchuravy
Copy link
Contributor

vchuravy commented Sep 9, 2021

Bugzilla Link 51810
Resolution FIXED
Resolved on Sep 10, 2021 09:32
Version trunk
OS All
Blocks #50580
CC @andykaylor,@phoebewang,@tstellar
Fixed by commit(s) ae8507b 77f2430

Extended Description

Would be nice to backport https://reviews.llvm.org/D109203 landed as https://reviews.llvm.org/rGae8507b0df738205a6b9e3795ad34672b7499381

@vchuravy
Copy link
Contributor Author

vchuravy commented Sep 9, 2021

assigned to @topperc

@tstellar
Copy link
Collaborator

tstellar commented Sep 9, 2021

Craig, Andy what do you think about this?

@andykaylor
Copy link
Contributor

It looks reasonable to me, but I'm not familiar with the problem this was fixing. I'm adding Pengfei, as he reviewed the original patch and should know more.

@phoebewang
Copy link
Contributor

This patch has low risk since it only changes for 32 bits, which is indeed a bug for the use of r11d.
@​Valentin, it should be better if you can provide some background, e.g, if there's a real case that failed for it and this patch works for that case.

@vchuravy
Copy link
Contributor Author

Yes we hit this reliably with our test suite for Julia. As usual we can carry the patch, but since it is straightforward, back porting it would be nice.

@phoebewang
Copy link
Contributor

Thanks Valentin. I think it's OK to backport.

@tstellar
Copy link
Collaborator

Merged: 77f2430

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla tools:llc
Projects
None yet
Development

No branches or pull requests

4 participants