[libc] disable strfroml entrypoint on aarch64 #101854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: Schrodinger ZHU Yifan (SchrodingerZhu) ChangesDisable strfroml entrypoint on aarch64 to please clang-11 buildbots Full diff: https://github.com/llvm/llvm-project/pull/101854.diff 1 Files Affected:
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 6a23ecbfa784b..dff8f25142dd9 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -189,7 +189,8 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.srand
libc.src.stdlib.strfromd
libc.src.stdlib.strfromf
- libc.src.stdlib.strfroml
+ # TODO: long double support is buggy with clang-11. Re-enable when buildbots are upgraded.
+ # libc.src.stdlib.strfroml
libc.src.stdlib.strtod
libc.src.stdlib.strtof
libc.src.stdlib.strtol
|
|
I don't think you can call this an NFC since it disables functionality. You should also link the Buildbot failure and/or the issue you opened in the PR description. |
SchrodingerZhu
changed the title
|
@overmighty fair enough. It is "NFC" implementation-wise but indeed the PR changes behavior on aarch64 architecture :D. I will link the issue in comments. |
|
Updated. PTAL. |
lntue
approved these changes
Aug 4, 2024
banach-space
pushed a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 7, 2024
Disable `strfroml` entrypoint on aarch64 to please clang-11 buildbots. Detailed in llvm#101846. This is not a fix for llvm#101846 so I will keep the issue open until our buildbot is updated or other mitigation is applied.
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Aug 15, 2024
Disable `strfroml` entrypoint on aarch64 to please clang-11 buildbots. Detailed in llvm#101846. This is not a fix for llvm#101846 so I will keep the issue open until our buildbot is updated or other mitigation is applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable
strfromlentrypoint on aarch64 to please clang-11 buildbots. Detailed in #101846. This is not a fix for #101846 so I will keep the issue open until our buildbot is updated or other mitigation is applied.