From 60bd86eda4ab165cad55436a2ab431b36cd2db10 Mon Sep 17 00:00:00 2001 From: powderluv Date: Sun, 28 Aug 2022 11:28:23 -0700 Subject: [PATCH 1/3] Disable LTC by default until upstream revert relands Tracked with the WIP https://github.com/llvm/torch-mlir/pull/1292 --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 1a07e7b10fb..bf031b772c5 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -49,7 +49,7 @@ if(TORCH_MLIR_ENABLE_MHLO) endif() endif() -option(TORCH_MLIR_ENABLE_LTC "Enables LTC backend" ON) +option(TORCH_MLIR_ENABLE_LTC "Enables LTC backend" OFF) if(TORCH_MLIR_ENABLE_LTC) set(ENV{TORCH_MLIR_ENABLE_LTC} 1) From 7db30ebed18116d2d508c23286f0081dc3643bf6 Mon Sep 17 00:00:00 2001 From: powderluv Date: Sun, 28 Aug 2022 11:52:40 -0700 Subject: [PATCH 2/3] Disable LTC e2e tests temporarily --- .github/workflows/buildAndTest.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/buildAndTest.yml b/.github/workflows/buildAndTest.yml index 1af6cdc0fef..84cec511a35 100644 --- a/.github/workflows/buildAndTest.yml +++ b/.github/workflows/buildAndTest.yml @@ -183,4 +183,5 @@ jobs: if: ${{ matrix.os-arch == 'ubuntu-x86_64' && matrix.llvm-build == 'in-tree' }} run: | export PYTHONPATH="$GITHUB_WORKSPACE/build/tools/torch-mlir/python_packages/torch_mlir" - python -m e2e_testing.torchscript.main --config=lazy_tensor_core -v + echo "LTC tests disabled temporarily. https://github.com/llvm/torch-mlir/pull/1292" + # python -m e2e_testing.torchscript.main --config=lazy_tensor_core -v From 2196c5092567eb6f96a67193885623f7df6a0c8f Mon Sep 17 00:00:00 2001 From: powderluv Date: Sun, 28 Aug 2022 14:55:49 -0700 Subject: [PATCH 3/3] Update setup.py Disable LTC in setup.py temporarily until upstream is fixed. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 53a0346d98e..929c27e8ac7 100644 --- a/setup.py +++ b/setup.py @@ -81,7 +81,7 @@ def run(self): f"-DCMAKE_VISIBILITY_INLINES_HIDDEN=ON", f"-DCMAKE_C_VISIBILITY_PRESET=hidden", f"-DCMAKE_CXX_VISIBILITY_PRESET=hidden", - f"-DTORCH_MLIR_ENABLE_LTC={'ON' if int(os.environ.get('TORCH_MLIR_ENABLE_LTC', 1)) else 'OFF'}", + f"-DTORCH_MLIR_ENABLE_LTC={'OFF' if int(os.environ.get('TORCH_MLIR_ENABLE_LTC', 1)) else 'OFF'}", ] os.makedirs(cmake_build_dir, exist_ok=True)