Remove loading of Copilot Arena tab when env variable is not set (#3645)

lm-sys · Dec 20, 2024 · 8664268 · 8664268
1 parent 7a912c7
commit 8664268
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 16 deletions.
diff --git a/fastchat/serve/monitor/copilot_arena.py b/fastchat/serve/monitor/copilot_arena.py
@@ -7,12 +7,6 @@
 
 copilot_arena_leaderboard_url = os.getenv("COPILOT_ARENA_LEADERBOARD_URL")
 
-if not copilot_arena_leaderboard_url:
-    raise ValueError(
-        "COPILOT_ARENA_LEADERBOARD_URL environment variable is not set. "
-        "Please configure it to a valid URL."
-    )
-
 
 def process_copilot_arena_leaderboard(leaderboard):
     leaderboard = leaderboard.copy().loc[leaderboard["visibility"] == "public"]
@@ -41,9 +35,6 @@ def process_copilot_arena_leaderboard(leaderboard):
 
 
 def build_copilot_arena_tab():
-    if copilot_arena_leaderboard_url is None:
-        print("Copilot Arena Leaderboard URL is not set. Skipping this leaderboard.")
-        return
     response = requests.get(copilot_arena_leaderboard_url)
     if response.status_code == 200:
         leaderboard = pd.DataFrame(response.json()["elo_data"])

diff --git a/fastchat/serve/monitor/monitor.py b/fastchat/serve/monitor/monitor.py
@@ -1034,15 +1034,21 @@ def build_leaderboard_tab(
                 build_full_leaderboard_tab(
                     elo_results_text, model_table_df, model_to_score
                 )
-            try:
-                with gr.Tab("Copilot Arena Leaderboard", id=5):
-                    from fastchat.serve.monitor.copilot_arena import (
-                        build_copilot_arena_tab,
-                    )
 
+            from fastchat.serve.monitor.copilot_arena import (
+                build_copilot_arena_tab,
+                copilot_arena_leaderboard_url,
+            )
+
+            if copilot_arena_leaderboard_url:
+                with gr.Tab("Copilot Arena Leaderboard", id=5):
                     build_copilot_arena_tab()
-            except Exception as e:
-                print(f"Unable to build Copilot Arena's Leaderboard. Error: {e}")
+            else:
+                print(
+                    "Unable to build Copilot Arena's Leaderboard. "
+                    "COPILOT_ARENA_LEADERBOARD_URL environment variable is not set. "
+                    "Please configure it to a valid URL."
+                )
 
         if not show_plot:
             gr.Markdown(