Allow Peft models to share their base model #1905
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This adds a special environment variable that activates shared Peft model base weights. Currently when loading two Peft models that have the same base model, those model weights are loaded once. With this flag activated, all Peft models will share the same base model.
To make this work it requires a few work around due to how Huggingface's Peft model has implemented LoRA adapters, the most popular variant. These modify the base model's pytorch modules directly and thus adapters sharing the same base model must live within the same model object and a
set_adapter
method must be called to switch between them.Related issue number (if applicable)
Expands #1805
Checks
format.sh
to lint the changes in this PR.