Inconsistencies and oddities in web TS

[literat]

I came across this while making the DS-449:

1. Dropdown.ts refers to the visual CSS class DropdownWrapper, but should look for data-spirit-element

• refactor without this class reference, probably best by structure

2. It is not clear how the data configuration is handled: somewhere there is getOptions() (Dropdown), mostly just *.dataset directly

• mostly we work directly, but you could somehow unify the approach

3. configuration data attributes do not contain a spirit infix, e.g. data-max-file-size

• we want to fix this within BC v1

4. methods sometimes define an output type (: void etc.), sometimes not

• typescript can usually infer itself, so rather remove

5. some plugins have this.state, others either not at all (but could), or put individual properties directly into this

• we don't want to treat plugins like React, we don't want to use this.state, but rather separate class properties

6. events (resize, load, ...) are sometimes in constants, sometimes not

• we want to have ideally in constants

7. The packages/web/src/js/utils/{}tests{}/index.test.ts contains not only exports but also code

• indexes contain only imports/exports and not code, move to files named accordingly

8. js/utils usually don't have tests (or is this related to the previous point?)

• add tests

9. naming constants with class - CLASS_NAME, CLASSNAME, _CLASSNAME

• I would go the way of CLASS_NAME_ prefixes like we have events