Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redemption Periods for LNURL-Withdraw #15

Open
cos-it-is opened this issue Sep 20, 2023 · 4 comments
Open

Redemption Periods for LNURL-Withdraw #15

cos-it-is opened this issue Sep 20, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@cos-it-is
Copy link

Include the ability to set redemption periods for LNURL withdrawals.

Use case: To allow the purchase of gift vouchers through an ATM thermal printer. Insert FIAT, print gift voucher that has a pre-defined redemption period before expiry.

@dni dni self-assigned this Sep 21, 2023
@dni dni added the enhancement New feature or request label Sep 21, 2023
@cos-it-is
Copy link
Author

Would be good set between 1 day and like 6 or 12 months. The user can take the risk on volatility or use stable sats solution.

@dni
Copy link
Member

dni commented Sep 21, 2023

hm, i think just a date would do it

@cos-it-is
Copy link
Author

cos-it-is commented Sep 21, 2023

hm, i think just a date would do it

By having a set date only it isn't relative to the time of issue. With regards to the ATM, the withdrawal is created sporadically so a set date would make the validity of an invoice created today one day less than one created tomorrow and so on. The validity period should begin on creation. e.g. print today and it is valid for one month. Print in 7 days time, and it is valid for 1 month from printing.

Unless you're referring to creating an invoice and setting a date? But using date format will require proper implementation of NTP in endpoint devices.

From a device use case perspective, a modification to lnurldevices so that a user can set redemption periods for their device on a day time frame would work better. But maybe that is a separate issue? (lnbits/lnurldevice#21) A modification also to that extension?

@dni
Copy link
Member

dni commented Sep 22, 2023

ok i'm convinced lets do relative times :)

2nd. yep lnurldevice is independent of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants