Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not compatible with lnurl 0.5.2 #47

Closed
prusnak opened this issue Aug 14, 2024 · 1 comment · Fixed by #48
Closed

not compatible with lnurl 0.5.2 #47

prusnak opened this issue Aug 14, 2024 · 1 comment · Fixed by #48
Assignees
@dni

Comments

@prusnak
Copy link
Collaborator

prusnak commented Aug 14, 2024

when lnurl is bumped to 0.5.2 (see lnbits/lnbits#2619)

the withdraw extension stops working with:

Could not load extension `withdraw`: cannot import name 'MilliSatoshi' from 'lnurl.types' (......./pypoetry/virtualenvs/lnbits-YN5PyUh5-py3.12/lib/python3.12/site-packages/lnurl/types.py)

There is indeed no MilliSatoshi in lnurl.types anymore
@prusnak prusnak mentioned this issue Aug 14, 2024
Merged
@prusnak prusnak mentioned this issue Aug 15, 2024
Merged
@prusnak
Copy link
Collaborator Author

prusnak commented Aug 15, 2024

fix in #48

@dni dni closed this as completed in #48 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dni dni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix broken import of MilliSatoshi lnbits/withdraw
2 participants
@prusnak @dni