Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid-suite/test-description rules don't handle template literals #139

Closed
shusak opened this issue Aug 17, 2017 · 2 comments · Fixed by #237
Closed

valid-suite/test-description rules don't handle template literals #139

shusak opened this issue Aug 17, 2017 · 2 comments · Fixed by #237

Comments

@shusak
Copy link

shusak commented Aug 17, 2017

When the descriptions are a template literal, they are not processed by these rules.

The rules need to look to see if the argument is a TemplateLiteral and navigate to it's raw or cooked value to run the regEx on.

@hinhengchan
Copy link

+1, having the same issue for both rules valid-suite-description and valid-test-description

@lo1tuma
Copy link
Owner

lo1tuma commented Nov 13, 2019

I think we could only check template literals without any expressions or tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants