Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-debug enabled shouldn't exit the script on errors ... ever #1402

Closed
mstoykov opened this issue Apr 21, 2020 · 3 comments · Fixed by #1432
Closed

http-debug enabled shouldn't exit the script on errors ... ever #1402

mstoykov opened this issue Apr 21, 2020 · 3 comments · Fixed by #1432

Comments

@mstoykov
Copy link
Contributor

Currently, if http-debug is set and the dumping of the request or response results in an error k6 will exit with status code 1 ... which is unlikely to be what anyone wants ...

@berndhartzer
Copy link
Contributor

Is there some specific functionality needed to fix this, or is it just a matter of swapping Fatal() (which calls os.Exit(1)) with a different log level, such as Error() or Warn()?

@mstoykov
Copy link
Contributor Author

mstoykov commented May 4, 2020

No, it is just swapping it, I think. I don't know whether Error or Warn is better though 🤷‍♂️

You are welcome to make a PR, but we are currently working on PR 1007 (not linking it as it is huge as it is) and given that this bug has been this way for way too long, it seems unlikely we will once again stop working on 1007 to fix it, release it and then go back, as I've explained in other currently open PRs :(.

@berndhartzer
Copy link
Contributor

Ok cool, thanks. Well I made a PR. In the end I thought Error() is a better choice because it is dumping out an error. Happy for any feedback of course!

@na-- na-- closed this as completed in #1432 May 7, 2020
na-- pushed a commit that referenced this issue May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants