Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Js console fixes #1577

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Js console fixes #1577

merged 4 commits into from
Jul 30, 2020

Conversation

mstoykov
Copy link
Contributor

No description provided.

@mstoykov mstoykov added this to the v0.28.0 milestone Jul 29, 2020
@mstoykov mstoykov requested review from imiric and na-- July 29, 2020 11:56
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #1577 into master will increase coverage by 0.05%.
The diff coverage is 85.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   77.09%   77.14%   +0.05%     
==========================================
  Files         162      162              
  Lines       13252    13255       +3     
==========================================
+ Hits        10216    10225       +9     
+ Misses       2515     2509       -6     
  Partials      521      521
Impacted Files Coverage Δ
lib/executor/helpers.go 96.73% <0.00%> (ø)
lib/netext/httpext/httpdebug_transport.go 75.00% <50.00%> (ø)
js/console.go 95.23% <100.00%> (+0.23%) ⬆️
lib/netext/httpext/request.go 97.28% <100.00%> (+0.01%) ⬆️
stats/cloud/collector.go 79.23% <0.00%> (+0.54%) ⬆️
js/runner.go 83.73% <0.00%> (+0.69%) ⬆️
lib/testutils/minirunner/minirunner.go 82.14% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcab52...ad55420. Read the comment docs.

@mstoykov
http-debug: log to a logger and mark it's source
ec50b2a 
unfortunately this doesn't look all that well and the need for
bytes.ReaplceAll comes from the fact that `\r\n` breaks how logrus logs
it otherwise :(
@mstoykov
mark stacktraces with a source in the logs
ad55420
na--
na-- approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm tempted to ask for #1146 as well 😅 Given that we're making a minor breaking change in the console API, can't we go all the way and print objects sanely?

@mstoykov
Copy link
Contributor Author

I think we agreed that we want dop251/goja#162 to be fixed before we do that ?

@na--
Copy link
Member

na-- commented Jul 30, 2020

Yeah, sorry, I forgot... 😅

@mstoykov mstoykov mentioned this pull request Jul 30, 2020
Merged
@mstoykov mstoykov merged commit 8f4797d into master Jul 30, 2020
@mstoykov mstoykov deleted the jsConsoleFixes branch July 30, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@na-- na-- na-- approved these changes

@imiric imiric imiric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mstoykov @codecov-commenter @na-- @imiric