Enable some tests on Windows #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were flaky on AppVeyor, but seem to pass on GHA. TestRequestAndBatch and TestTracer failed consistently when I ran them, but I didn't look into refactoring yet.
na--
approved these changes
Nov 13, 2020
mstoykov
previously approved these changes
Nov 16, 2020
na--
previously approved these changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
- Coverage 71.52% 71.49% -0.03%
==========================================
Files 178 178
Lines 13719 13727 +8
==========================================
+ Hits 9812 9814 +2
- Misses 3295 3301 +6
Partials 612 612
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imiric
force-pushed
the
test/902-enable-windows
branch
from
1ff6f15
to
fc0b5be
Compare
na--
approved these changes
Nov 17, 2020
mstoykov
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were flaky on AppVeyor, but seem to pass on GHA. I ran the full suite a few times in https://github.com/imiric/k6/actions/runs/359816051 without any failures, so it seems safe to leave them on, unless they embarass me and fail now... :)
There are still two that failed consistently and weren't enabled:
TestRequestAndBatchandTestTracer. I'll look into refactoring them before closing #902, though that can also wait for another PR.