Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #1721 (cc @curvedriver). There were 2 separate bugs... 😞 Wildcards didn't catch 0-length matches, and when you blocked both a
domain
and asub.domain
, theHostnameTrie
stopped blocking thedomain
because thelen(t.children) == 0
check was no longer true (wrong assumption that you can't block both a top-level and a sub-domain). This script more succinctly demonstrates the issue, running it with k6 0.29.0 will fail all checks, whereas with this PR they all pass: